fix: isClass for minified class expression#64
Merged
thetutlage merged 1 commit intoadonisjs:11.xfrom Nov 3, 2025
Merged
Conversation
Member
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
N/A
❓ Type of change
📚 Description
Related change in sindresorhus/is#217, several of the Adonis packages seem to be using.
I was experimenting recently with bundling the Adonis codebase via ESBuild, and everything seemed to work. However when I minified the code, it broke in a strange way. It seemed to be due to the minification creating a class expression with
class{}, whichisClassdid not evaluate true for.It seems the other packages are now using
@sindresorhus/is, however this one still has the standaloneisClasshelper, so this is just adding my change from that repo here.📝 Checklist